https://bugzilla.redhat.com/show_bug.cgi?id=1767998
--- Comment #3 from Lyes Saadi <mail(a)lyes.eu> ---
It's a matter of preference, but I'd recommend putting each
build dependency in a separate line and sorting them alphabetically.
You can fold each mkdir+cp pair into install -Dp call to make it
shorter, but do at least use cp -p to preserve build-time timestamps.
I'll do it. Thanks for the advice :D!
Please use %make_build macro unless you have a good reason not to. I
don't see Fedora-mandated compiler flags being used during build, so please try adding
%set_build_flags before calling make and if that doesn't help, you might need to patch
the Makefile.
Yeah, just a little reason. The make file tries to install the systemd service
in /lib instead of /usr/lib (it only creates the folder, though). So, I thought
it was maybe better not to, especially that the program is pretty simple to
install manually. If you think I should do otherwise, tell me, I was myself not
sure if I should do it or not.
Also, you should run the tests
(
https://github.com/linux-on-mac/mbpfan#run-the-tests-optional) in %check section, if
possible.
The tests are optional and might fail if the fans are running too fast. While
installing from source, it is easy to understand to it's just a false positive,
a user using DNF won't and it'll print some scary errors.
See
https://github.com/linux-on-mac/mbpfan/issues/198
Thank you a lot for looking into my spec file :)!
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component