https://bugzilla.redhat.com/show_bug.cgi?id=1913870
code(a)musicinmybrain.net changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |code(a)musicinmybrain.net
Doc Type|--- |If docs needed, set a value
--- Comment #1 from code(a)musicinmybrain.net ---
This is not a full review, just a few things I saw at first glance.
There are several bundled libraries in src/3rdParty. See
https://docs.fedoraproject.org/en-US/packaging-guidelines/#bundling. In short,
if upstream supports building with an external copy, you must do so. Otherwise,
you must contact upstream requesting the ability to do so; then you may either
add a virtual Provides for the bundled library or, if you like, find a way to
patch it to unbundle yourself.
A number of files have copyright headers indicating they have licenses other
than MIT. All licenses from files that contribute to the final build need to be
in the License field, with some documentation of which license applies to which
parts. See
https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidel....
You can use licensecheck to help look for files that you need to examine.
You must validate the AppData XML file in %check; see
https://docs.fedoraproject.org/en-US/packaging-guidelines/AppData/#_app_d....
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component