https://bugzilla.redhat.com/show_bug.cgi?id=1039315
Christopher Meng <cickumqt(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC|cickumqt(a)gmail.com |
--- Comment #7 from Christopher Meng <cickumqt(a)gmail.com> ---
1. Why not BuildRequires: vala-devel but BuildRequires: vala-compat-devel?
2. I'm sure this spec is copied from elsewhere(you know):
Provides: google-music-frame = %{version}
Obsoletes: google-music-frame < 1.0.1
We never have this package before, and we don't need to provide that.
3. Why --skip-tests?
4. Sort out 1 style: $RPM_BUILD_ROOT%{_datadir}, no $RPM_BUILD_ROOT/%{_datadir}
$RPM_BUILD_ROOT%{_bindir}, no $RPM_BUILD_ROOT/%{_bindir}
5. %description:
Nuvola Player runs web interface of cloud music service in its own window and
provides integration with a Linux Desktop(system tray, Ubuntu sound menu, dock
menu and notifications).Currently supported services are Google Music,
Grooveshark, Hype Machine and 8tracks.
Well, Ubuntu what? Please improve it.
6. Sources tarball contains 2 dirs: external/ and licenses/ , please double
check them.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component