Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: psiconv : A conversion utility for Psion files
https://bugzilla.redhat.com/show_bug.cgi?id=442854
------- Additional Comments From huzaifas(a)redhat.com 2008-04-17 06:34 EST -------
(In reply to comment #2)
Full review done:
MUST FIX:
---------
-Missing BuildRequires: ImageMagick-devel bc
done
-The man page for psiconv-config should be in -devel
done
-The doc files under /usr/share/psiconv should be moved to %doc of
-devel, iow do this after make install:
mv $RPM_BUILD_ROOT%{_datadir}/%{name} _doc
And then add: " %doc _doc/*" to %files of -devel
done
-License should be GPLv2+ not GPLv2 as far as I can see, any
particular reason
you've used GPLv2?
done
SPEC:
http://huzaifas.fedorapeople.org/spec/psiconv.spec
SRPM:
http://huzaifas.fedorapeople.org/srpms/psiconv-0.9.8-1.fc8.src.rpm
--
Configure bugmail:
https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.