Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=730888
Douglas Schilling Landgraf <dougsland(a)redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flag|needinfo?(dougsland@redhat. |
|com) |
--- Comment #3 from Douglas Schilling Landgraf <dougsland(a)redhat.com> 2011-08-23
23:46:57 EDT ---
Hello James,
Thanks for your review, please see below my comments/fixes:
[ FAIL ] MUST: A package must own all directories that it creates. If
it does
not create a directory that it uses, then it should require a package
which does create that directory.
This package should "Requires: nagios-plugins" to ensure
that
{_libdir}/nagios/plugins is available upon install.
Fixed.
[ WARN ] SHOULD: your package should contain man pages for
binaries/scripts. If
it doesn't, work with upstream to add them where they make sense.[34]
Not a hard requirement, other nagios-plugins-* don't seem to provide manpages.
It might be helpful to include a README
File README is included already.
[ WARN ] - In the upstream setup.py included in the tarball, there
appears
to be a copy'n'paste error. Should the name be changed to:
- setup(name='python-confparser', version='1.0.0',
+ setup(name='nagios-plugins-rhev', version='1.0.0',
Fixed
# rpm2cpio nagios-plugins-rhev-1.0.0-1.fc15.src.rpm | cpio -id
23 blocks
# md5sum nagios-plugins-rhev-1.0.0.tar.gz
85fa94a6bcbf1937ecdf3bd010867559 nagios-plugins-rhev-1.0.0.tar.gz
# curl
https://github.com/dougsland/nagios-plugins-rhev/raw/master/nagios-plugins
-rhev-1.0.0.tar.gz
2>/dev/null | md5sum
987d8ef38a72cdc8811a5752825c160a -
Fixed
New files available:
https://github.com/dougsland/nagios-plugins-rhev/raw/master/nagios-plugin...
https://github.com/dougsland/nagios-plugins-rhev/raw/master/nagios-plugin...
Thanks
Douglas
--
Configure bugmail:
https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.