https://bugzilla.redhat.com/show_bug.cgi?id=2249863
Fabio Valentini <decathorpe(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |POST
Assignee|nobody(a)fedoraproject.org |decathorpe(a)gmail.com
Flags| |fedora-review+
--- Comment #9 from Fabio Valentini <decathorpe(a)gmail.com> ---
Thank you for submitting your patches to upstream! Package looks good to me.
Two tips / hints for the future:
1. Please use "rust2rpm -p" for applying changes to Cargo.toml.
Changes to Cargo.toml can affect the spec file that is generated by rust2rpm,
so these changes need to happen at a stage where the changes *can* affect spec
generation (which is what "rust2rpm -p" is for).
2. You can store a rust2rpm.toml config file in dist-git to preserve some
changes for future updates:
```toml
[requires]
build = ["pkgconfig(liblz4)"]
lib = ["pkgconfig(liblz4)"]
```
This will automatically add the "pkgconfig(liblz4)" BuildRequires and
"-devel"
package Requires when running rust2rpm again.
===
Package was generated with rust2rpm, simplifying the review.
- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification and is acceptable for Fedora
- license file is included with %license in %files (manually included from
upstream project for now)
- package complies with Rust Packaging Guidelines
Package APPROVED.
===
Recommended post-import rust-sig tasks:
- set up package on
release-monitoring.org:
project: $crate
homepage:
https://crates.io/crates/$crate
backend: crates.io
version scheme: semantic
version filter: alpha;beta;rc;pre
distro: Fedora
Package: rust-$crate
- add @rust-sig with "commit" access as package co-maintainer
(should happen automatically)
- set bugzilla assignee overrides to @rust-sig (optional)
- track package in koschei for all built branches
(should happen automatically once rust-sig is co-maintainer)
--
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2249863
Report this comment as SPAM:
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=rep...