https://bugzilla.redhat.com/show_bug.cgi?id=1081434
--- Comment #8 from Michael Schwendt <bugs.michael(a)gmx.net> ---
Name: ip2location-c
Summary: IP2location headers, libraries
https://fedoraproject.org/wiki/Packaging:Guidelines#Summary_and_description
https://fedoraproject.org/wiki/Examples_of_good_package_summaries
Only repeating the name of the software/package typically is not a good
summary. Plus, the base package does not contain any headers anymore. One
rather obvious and generic summary would be:
Summary: Geo IP solution library
The %description expands on that.
Run rpmlint (or rpmlint -i for more helpful output) on the src.rpm and all
built rpms. Feel free to ignore obvious false positives in the report, but fix
anything else. Preferably add a comment here about whether/when you think what
rpmlint reports is correct or incorrect.
Group: Development/Libraries
The base package group for runtime libraries is "System Environment/Libraries".
%clean
rm -rf %{buildroot}
https://fedoraproject.org/wiki/Packaging:Guidelines#.25clean
%files
%defattr(-,root,root,-)
https://fedoraproject.org/wiki/Packaging:Guidelines#File_Permissions
%package devel
Requires: %{name} = %{version}-%{release}
https://fedoraproject.org/wiki/Packaging:Guidelines#Requiring_Base_Package
Provides: ip2location-c-devel = %{version}-%{release}
Obsoletes: ip2location-c-devel < %{version}-%{release}
These two lines make no sense at all. The subpackage is named
ip2location-c-devel already. There are automatic Provides for it - just query
the built rpms and examine them.
Is this is the reason you are asked for License clarification
Not only.
1) The source files ought to contain a reference to the used license:
https://www.gnu.org/licenses/gpl-faq.html#NoticeInSourceFile
2) Also consider including a copy of the GPL to follow this advice:
https://www.gnu.org/licenses/gpl-faq.html#v3HowToUpgrade
3) An old copy of the imath library is bundled, which applies "MIT/X11 (BSD
like" licensing terms:
https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#Multiple_Lic...
https://github.com/creachadair/imath
https://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component