https://bugzilla.redhat.com/show_bug.cgi?id=2112474
Kashyap Chamarthy <kchamart(a)redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags| |needinfo?(mhroncok(a)redhat.c
| |om)
--- Comment #5 from Kashyap Chamarthy <kchamart(a)redhat.com> ---
(In reply to Miro Hrončok from comment #4)
Hi, Miro. Thanks for the feedback. A quick question further below:
Note that:
%install
...
%pyproject_save_files qemu
Only makes sense with:
%files -n python3-%{pkg_name} -f %{pyproject_files}
%doc README.rst
%doc html
%{_bindir}/qmp-shell
%{_bindir}/qmp-shell-wrap
Yep, noted.
I also highly recommend not listing BuildRequires like pip and
setuptools
manually, but using %pyproject_buildrequires instead.
Thanks for the macro. So that macro should be used this way, I presume?
...
%generate_buildrequires
%pyproject_buildrequires
...
Also, I wonder if that should be "%pyproject_buildrequires -r", to generate
requirements, or if just the plain "%pyproject_buildrequires" suffices.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2112474