https://bugzilla.redhat.com/show_bug.cgi?id=1152653
--- Comment #5 from Petr Pisar <ppisar(a)redhat.com> ---
(In reply to Scott Talbert from comment #3)
A few initial comments.
> Release: 0.1.%{miniz_rc}%{?dist}
I'm thinking this should just be 1.%{miniz_rc}%{?dist} since this is a
post-release (ie, 1.15r4 came after 1.15) rather than a pre-release. See
here:
http://fedoraproject.org/wiki/Packaging:NamingGuidelines#NonNumericRelease
I thought this is a release-candidate, i.e. a pre-release. There is no 1.15
listed on the download page. And the changelog in the header file lists 1.15
after 1.15r4.
> gcc %{?__global_ldflags} -fPIC -shared %{name}.o -o
lib%{name}.so
I'm wondering if we should be adding soname versioning? It doesn't seem
like upstream is changing much but it seems like it might be good to have.
I do not think this is good idea because SONAME is part of ABI. Having Fedora
specific ABI is not good. I know this code is a library nowhere now, but that
could change in the future. I want to keep the differences as little as
possible.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component