Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=499319
--- Comment #11 from Bryson Lee <bamablee(a)gmail.com> 2009-06-16 01:19:57 EDT ---
Sorry for the hiatus...(In reply to comment #6).
- Doesn't the version macro at
http://fedoraproject.org/wiki/Packaging/Tcl#arch-specific_packages
work? Where does it fail?
- Have you tried the configure argument --libdir=%{tcl_sitearch} to change the
default install location?
Still need to investigate these two items.
- Do you really need to specify --with-tcl=%{_libdir}? OK, on
multiarch arches
with both 32- and 64-bit versions installed you might get into trouble if
configure picks up the wrong version. No hurt having this if you think it's
necessary.
I had exactly this issue when building originally on an x86_64 machine
- License tag should be MIT (see
http://fedoraproject.org/wiki/Licensing ). But
this is really not necessary, since CMU is compatible with GPL and License:
GPLv3+ is enough.
MUST: The License field in the package spec file must match the
actual license.
NEEDSFIX
- See comment above, license tag should be just GPLv3+.
It appears that the author has licensed his TCL-specific wrapper code under
GPLv3+; however, the NetSNMP source files that are also included in the package
explicitly call out the CMU license. Hence my original choice of "CMU and
GPLv3+". I have no particular axe to grind about this, so if just GPLv3+ is
sufficient I'll update the specfile accordingly.
MUST: The sources used to build the package must match the upstream
source, as
provided in the spec URL. OK
UST: The package MUST successfully compile and build into binary rpms. OK
MUST: The spec file MUST handle locales properly. N/A
MUST: Optflags are used and time stamps preserved. NEEDSFIX
- Even though the files that are installed are generated, it's always nice to
preserve time stamps in install phase. Use INSTALL="install -p" as argument to
make install.
Will do.
MUST: Packages containing shared library files must call ldconfig.
N/A
MUST: A package must own all directories that it creates or require the package
that owns the directory. ~OK
- Instead of
%dir %{tcl_sitearch}/%{realname}%{version}
%{tcl_sitearch}/%{realname}%{version}/*.so
%{tcl_sitearch}/%{realname}%{version}/pkgIndex.tcl
just put
%{tcl_sitearch}/%{realname}%{version}/
as this will own the directory and everything in it.
Right...wondered about that. A couple of other Fedora TCL extension packages I
looked at did it as in the current iteration of the specfile, so I went with
that approach. Will adjust to use %dir instead.
MUST: Files only listed once in %files listings. OK
MUST: Debuginfo package is complete. OK
MUST: Permissions on files must be set properly. OK
MUST: Clean section exists. OK
MUST: Large documentation files must go in a -doc subpackage. N/A
MUST: All relevant items are included in %doc. Items in %doc do not affect
runtime of application. NEEDSFIX
- Add AUTHORS. BUGS and TODO should otherwise be included, but now they just
contain instructions to grep the code.
Will do.
--
Configure bugmail:
https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.