https://bugzilla.redhat.com/show_bug.cgi?id=2005752
mkulik(a)redhat.com changed:
What |Removed |Added
----------------------------------------------------------------------------
Doc Type|--- |If docs needed, set a value
CC| |mkulik(a)redhat.com
--- Comment #1 from mkulik(a)redhat.com ---
Hi,
I'm no sure I will have time to make a full review but here are few points that
caught my attention:
* Missing LICENSE file
* You are using sources from PyPI. Do you have a reason to use those instead of
official ones from Github ?
More information about this topic here:
https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_source...
* I can see that tests are not performed according to guidelines. This is a one
reason why building from PyPI is not always a great idea
(missing tox files). More information here:
https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_runnin...
* From changelog I can see that you un-retired this package, it would be good
idea to update macros in spec file according to guidelines
https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_deprec...
Esthetic issues (aka rpmlint):
It would be nice to fix those or add exceptions with a comment if necessary.
* executable-script /usr/lib/python3.10/site-packages/kafka/record/_crc32c.py
644 /usr/bin/env python
* python3-kafka.noarch: E: description-line-too-long This module provides
low-level protocol support for Apache Kafka as well as high-level
* python3-kafka.noarch: E: description-line-too-long consumer and producer
classes. Request batching is supported by the protocol as well as
* python3-kafka.noarch: E: description-line-too-long broker-aware
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2005752