https://bugzilla.redhat.com/show_bug.cgi?id=2054708
Neal Gompa <ngompa13(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
--- Comment #2 from Neal Gompa <ngompa13(a)gmail.com> ---
Initial spec review:
%global use_flight 1
%global use_gandiva 0
%global use_mimalloc 0
%global use_ninja 1
# TODO: Enable this. This works on local but is fragile on GitHub Actions and
# Travis CI.
%global use_s3 0
%global have_rapidjson 1
%global have_re2 1
%global have_utf8proc 1
Consider converting these to build conditions instead:
https://rpm-software-management.github.io/rpm/manual/conditionalbuilds.html
ExcludeArch: i686 armv7hl
This should be "ExcludeArch: %{ix86} %{arm32}" instead.
If you need RHEL 8 compatibility, then substitute %{arm32} for %{arm}.
Requires: boost-system
Requires: boost-filesystem
Requires: brotli
These are unnecessary, as RPM will autogenerate library dependencies for your.
%setup -q -n apache-arrow-%{version}
%patch0001 -p1
This can be simplified to "%autosetup -p1 -n apache-arrow-%{version}
mkdir cpp/build
pushd cpp/build
%cmake .. \
We already build out of tree by default:
https://fedoraproject.org/wiki/Changes/CMake_to_do_out-of-source_builds
You can force this for RHEL 8 by putting the following in your spec: "%undefine
__cmake_in_source_build"
meson setup build \
Please use %meson here.
cd build && %ninja_build
Please use %meson_build here.
pushd c_glib/build
DESTDIR=$RPM_BUILD_ROOT %ninja_install
popd
Please use %meson_install here.
The rest of the spec is a jumble where all the subpackages are at the bottom
and the formatting makes it difficult to read.
If you're going to keep them all together like that, please consider organizing
it so all package definitions are at the top of the spec, similar to
transactional-update:
https://src.fedoraproject.org/rpms/transactional-update/blob/rawhide/f/tr...
--
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2054708