https://bugzilla.redhat.com/show_bug.cgi?id=1765591
Jaroslav Škarvada <jskarvad(a)redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |MODIFIED
Flags| |fedora-review+
--- Comment #3 from Jaroslav Škarvada <jskarvad(a)redhat.com> ---
(In reply to Jan Rodák from comment #2)
I fixed the issues. Here are new links to Spec and SRPM files.
I think the following is not needed:
%global name oval-graph
%global module oval_graph
%global version 0.0.2
...
Name: %{name}
Version: %{version}
...
Source0:
https://files.pythonhosted.org/packages/source/o/%{name}/%{module}-%{vers...
You could probably simplify it to:
%global pypi_name oval_graph
Name: oval-graph
Version: 0.0.2
Source0: %pypi_source
This also automatically defines %{name} and %{version} macros which you could
use later in the spec. Also IMHO alternatively instead of the pypi_name
probably also the srcname could be used. But if you as the upstream decides the
the correct upstream name is with the underscore "_" I would have no problem
with the "oval_graph" package name.
Another minor thing, you introduced spurious LF in the end of the spec file.
Nevertheless this all seems minor, so approving.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component