https://bugzilla.redhat.com/show_bug.cgi?id=2165399
--- Comment #16 from Carl George 🤠 <carl(a)redhat.com> ---
What's the purpose for setting __brp_check_rpaths to nil? Whatever it is
please include it as a comment above the macro definition.
What's the purpose of defining __python? The comment says it is to bytecompile
with Python 3, but that should be the default now. I suspect this is something
left over from before that was the case, so it can probably be removed.
The lua_scripting conditional is disabled on %{power64} because luajit isn't
available on that arch. luajit is also not available on s390x, so the %ifarch
should be updated to include that as well.
Please run licensecheck on the sources and update the license fields
accordingly. There are many more licenses involved here than just
GPL-2.0-or-later.
Also review the deps directory and see which bundled libraries you can
unbundled. All of them must be either unbundled or marked as bundled libraries
(provides and license fields).
Please switch negated with conditions (e.g. `%if ! %{with x264}`) to without
conditions (e.g. `%if %{without x264}`) for readability.
Currently the license files are only included in obs-studio. It's possible to
install obs-studio-libs subpackage without getting the license files. The
license files must be installed when any subpackage combination is installed.
You could either include the license files in all subpackages, or perhaps move
the license files to obs-studio-libs, since both obs-studio and
obs-studio-devel require it.
--
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2165399