https://bugzilla.redhat.com/show_bug.cgi?id=2240617
--- Comment #13 from Remi Collet <fedora(a)famillecollet.com> ---
(In reply to Xavier Bachelot from comment #12)
A couple comments.
- For my education, could you please explain ?
```
# For compatibility with SCL
%undefine __brp_mangle_shebangs
This is only for my repository, with Software Collection
allowing to run the provided command with enabled collection
```
- Typo : `# disabled as phpunit not availble` --> available
Fixed
- Add a comment explaining upstream tarball is not usable due to missing
tests, etc...
Fixed
- In %%files, spurious line :
```
# remirepo:1
Only a comment ;)
This is design ro remove next line(s) with I copy from my repo to fedora one
```
- In %%files, I believe the following line has lost its purpose nowadays:
```
%{!?_licensedir:%global license %%doc}
```
Still needed for EL-7 ;)
- I find using ':' rather than '#' for commented lines to be confusing,
but
that is probably just me
I use ':' as this appears in the build output (and avoid duplicate output of
'echo')
I have removed my repo specific stuff
Spec URL:
https://rpms.remirepo.net/temp/php-nikic-php-parser5.spec
SRPM URL:
https://rpms.remirepo.net/temp/php-nikic-php-parser5-5.0.2-1.fedora.src.rpm
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2240617
Report this comment as SPAM:
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=rep...