https://bugzilla.redhat.com/show_bug.cgi?id=1309795
--- Comment #1 from David Tardon <dtardon(a)redhat.com> ---
* If this is only for Fedora and EPEL-7, why do you change __global_ldflags for
0%{rhel} < 7?
* Is there a reason you are not passing %{?_smp_mflags} to make to allow
parallel build?
* Is there a reason to BuildRequire pkgconfig? I don't see it being used
anywhere...
* IMO the library symlinks should be relative.
* Consider putting the variables repeated in both make calls into a macro.
* Consider putting repeated parts of the gfortran calls into a macro.
* Consider using a build conditional
(
http://www.rpm.org/wiki/PackagerDocs/ConditionalBuilds) for the conditional
handling of docs.
* Consider using install consistently (instead of cp -p, possibly also instead
of mkdir -p).
But these are mostly cosmetic, so I am going to approve this.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component