https://bugzilla.redhat.com/show_bug.cgi?id=977116
--- Comment #8 from Pavel Alexeev (aka Pahan-Hubbitus) <pahan(a)hubbitus.info> ---
(In reply to Volker Fröhlich from comment #6)
I have no idea what that crashhandler binary does. It has no help, no
man page
and it doesn't say a lot anyway. I'd really consider prefixing the name or even
removing it. It doesn't seem to be meant for standalone execution. I wonder if
it should really be in bindir then.
It does what name speak: handle application
crash if happened. It does not
intended to be called by user. I fully agree with you what prefixed name would
be much more appropriate or even other location.
Unfortunately that name hardcoded in src:
https://github.com/pgmodeler/pgmodeler/blob/master/main/src/main.cpp and I do
not willing patch. I have ask upstream about it:
https://github.com/pgmodeler/pgmodeler/issues/282
Where's that "_r1" in the version from? Are you sure
you want that as part of
the version and not release?
From authors changelog:
https://github.com/pgmodeler/pgmodeler/blob/master/CHANGELOG.md
The Qt patches are irrelevant for upstream or already included? I
usually
try to have a comment about the status in the spec file or the patch.
I treat it as
"Fedora-specific" and did not send upstream. Comment "for current
Fedora releases" is not clear state it? It is just my fast backport attempt.
Pgmodeler developed to work with Qt5 which is not Fedora stable releases yet.
I'm not sure if everything that is below /etc really belongs
there. I also
found an icon there, by the way.
Logo, not icon. What you think appropriate path
for it? /usr/share/pgmodeler I
suppose? Most other files is *.conf and *.dtd which may be treated as conf
correctly.
The bash completion script should be
handled differently too
There no bash completions scripts.
I think you are by mistake speak about %{_sysconfdir}/profile.d/%{name}.bash?
It is just used to set environment variables appropriately as theys used by
application for function properly.
pgmodeler.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libutils.so.1.0.0 /lib64/libpq.so.5
pgmodeler.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libutils.so.1.0.0 /lib64/libQtGui.so.4
pgmodeler.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libutils.so.1.0.0 /lib64/libxml2.so.2
pgmodeler.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libutils.so.1.0.0 /lib64/libXext.so.6
pgmodeler.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libutils.so.1.0.0 /lib64/libX11.so.6
pgmodeler.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libutils.so.1.0.0 /lib64/libm.so.6
pgmodeler.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libpgmodeler.so.1.0.0 /lib64/libpq.so.5
pgmodeler.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libpgmodeler.so.1.0.0 /lib64/libxml2.so.2
pgmodeler.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libpgmodeler.so.1.0.0 /lib64/libXext.so.6
pgmodeler.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libpgmodeler.so.1.0.0 /lib64/libX11.so.6
pgmodeler.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libpgmodeler.so.1.0.0 /lib64/libm.so.6
pgmodeler.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libdbconnect.so.1.0.0 /lib64/libQtGui.so.4
pgmodeler.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libdbconnect.so.1.0.0 /lib64/libxml2.so.2
pgmodeler.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libdbconnect.so.1.0.0 /lib64/libXext.so.6
pgmodeler.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libdbconnect.so.1.0.0 /lib64/libX11.so.6
pgmodeler.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libdbconnect.so.1.0.0 /lib64/libm.so.6
pgmodeler.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libobjrenderer.so.1.0.0 /lib64/libpq.so.5
pgmodeler.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libobjrenderer.so.1.0.0 /lib64/libxml2.so.2
pgmodeler.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libobjrenderer.so.1.0.0 /lib64/libXext.so.6
pgmodeler.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libobjrenderer.so.1.0.0 /lib64/libX11.so.6
pgmodeler.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libpgmodeler_ui.so.1.0.0 /lib64/libpq.so.5
pgmodeler.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libpgmodeler_ui.so.1.0.0 /lib64/libxml2.so.2
pgmodeler.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libpgmodeler_ui.so.1.0.0 /lib64/libXext.so.6
pgmodeler.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libpgmodeler_ui.so.1.0.0 /lib64/libX11.so.6
pgmodeler.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libparsers.so.1.0.0 /lib64/libpq.so.5
pgmodeler.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libparsers.so.1.0.0 /lib64/libQtGui.so.4
pgmodeler.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libparsers.so.1.0.0 /lib64/libpthread.so.0
pgmodeler.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libparsers.so.1.0.0 /lib64/libXext.so.6
pgmodeler.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libparsers.so.1.0.0 /lib64/libX11.so.6
pgmodeler.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libparsers.so.1.0.0 /lib64/libm.so.6
There's some unnecessary linking going on. If these libraries are meant to
be used by other applications than that GUI, that should probably be
resolved.
I don't known other usages.
The locale script doesn't work because the locales are expected
to have some
kind of prefix to fr_FR. If you prefix them with something like pgmodeler_
and run %find_lang %{name} --with-qt, it works.
Will them then work or patching
needed?
In my experience, you don't need to BR gettext.
Guidelines
said it needed.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=YSQPLTkEw4&a=cc_unsubscribe