https://bugzilla.redhat.com/show_bug.cgi?id=1466961
--- Comment #8 from Hannes Frederic Sowa <hannes(a)stressinduktion.org> ---
Hi,
(In reply to Dave Love from comment #6)
(In reply to Hannes Frederic Sowa from comment #5)
> Do I need to add a version to bundled(gnulib)? rpmlint complains right now.
Yes, I noticed that. You can't add a version, as it doesn't have one.
I'd just note/explain the error in the spec file.
According to rpm --whatprovides 'bundled(gnulib)' at least some libraries
specify version attributes. I just couldn't figure out yet how they do it.
You don't need to remove buildroot in %install these days, but it
doesn't
hurt.
Yep, I understood. I did it for grepability and cosmetic reasons. ;)
Also the packaging guidelines say not to use macros like %_rm
I will change that.
> Dave, I would love to make this package compatible to EPEL. I am
going to
> read into that but feel free to dump any links on me. :)
I'll attach a patch. I realize it's only really for el6, but _I think_ the
location for completions should be changed on others, as in the patch.
Otherwise the diff is mostly moot. (I don't know if using pkg-config is the
right
way to get the completions directory.) Handling completions should be in
packaging guidelines.
You do need to own the completions directories with %dir anyhow, which I
patched in.
Hope that helps, and apologies if I'm stepping on reviewer toes.
No no, any help is welcome. Thanks a lot for the patch. Can I just use it and
apply it to my version? How can I attribute your help in the spec file
correctly?
Thanks!
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component