https://bugzilla.redhat.com/show_bug.cgi?id=1176273
Raphael Groner <projects.rg(a)smart.ms> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |projects.rg(a)smart.ms
--- Comment #3 from Raphael Groner <projects.rg(a)smart.ms> ---
Hi Martin,
there are some hints for your spec file. Maybe I can do the official review as
well.
* SHOULD consider to name the package 'asqp' as upstream does partly for the
project name? Well, I can see that the source tarball is using that full name
like in the subject.
https://fedoraproject.org/wiki/Packaging:NamingGuidelines#General_Naming
* SHOULD remove the Group tag cause it's obosolete. Note: This tag is
deprecated since Fedora 17.
https://fedoraproject.org/wiki/How_to_create_an_RPM_package#SPEC_file_ove...
* MUST use a valid Source URL, or add a comment how to build the tarball.
https://fedoraproject.org/wiki/Packaging:SourceURL?rd=Packaging/SourceURL
This?
http://www.stuff-o-matic.com/asgp/download/download.php?platform=source
* MUST build with mock and koji (scratch) to ensure all BR are correct.
https://fedoraproject.org/wiki/Packaging:Guidelines#BuildRequires
https://fedoraproject.org/wiki/Using_the_Koji_build_system#Scratch_Builds
* SHOULD fix/patch CMakeLists.txt to not enforce docbook2x as it seems to
create conflicts. And please send your patch to upstream, do they know about
that issue?
https://fedoraproject.org/wiki/Packaging:Guidelines#All_patches_should_ha...
# Cmake suggests it but "parser error" will be got.
BuildConflicts: docbook2x
* SHOULD what is "Plee the Bear"? How is it related to this package? You
won't
be able to create two individual subpackges for that 'bear' and
'bear-factory'
stuff. So consider to package that separately and unbundle.
https://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries
of the Bear Engine for Plee the Bear & Andy's Super Great
Park.
* MUST 'Require: hicolor-icon-theme' cause of the folder ownership.
https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelin...
%files
…
%{_datadir}/icons/hicolor/*/apps/asgp.png
* MUST (when possible) use the %cmake macro to avoid relisting of all those
parameters like RPATH etc.
https://fedoraproject.org/wiki/Packaging:Cmake
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component