https://bugzilla.redhat.com/show_bug.cgi?id=1202604
Zbigniew Jędrzejewski-Szmek <zbyszek(a)in.waw.pl> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags|fedora-review? |fedora-review+
|needinfo?(zbyszek(a)in.waw.pl |
|) |
--- Comment #18 from Zbigniew Jędrzejewski-Szmek <zbyszek(a)in.waw.pl> ---
Packaging looks good, the comments above were all addressed, rpmlint output is
OK.
sscg.noarch: W: no-documentation
sscg.noarch: W: no-manual-page-for-binary sscg
1 packages and 0 specfiles checked; 0 errors, 2 warnings.
Package is APPROVED.
I found another small issue, which I think should be resolved before the
package is submitted:
DEFAULT_CA_CERT = "/etc/pki/ca-trust/source/anchors", but
/etc/pki/ca-trust/source/anchors is a directory, owned by ca-certificates. So
renaming the tempfile fails:
$ sscg --package foo --cert-file /tmp/file1 --cert-key-file /tmp/file2
--country pl --state '' --locality None --organization None
--organizational-unit www --hostname bupkis.localdomain.
Traceback (most recent call last):
File "/usr/bin/sscg", line 9, in <module>
load_entry_point('sscg==0.4.0', 'console_scripts', 'sscg')()
File "/usr/lib/python3.4/site-packages/sscg/main.py", line 183, in main
crypto.dump_certificate(options.cert_format, ca_cert))
File "/usr/lib/python3.4/site-packages/sscg/__init__.py", line 69, in
write_secure_file
delete=False)
File "/usr/lib64/python3.4/tempfile.py", line 460, in NamedTemporaryFile
(fd, name) = _mkstemp_inner(dir, prefix, suffix, flags)
File "/usr/lib64/python3.4/tempfile.py", line 200, in _mkstemp_inner
fd = _os.open(file, flags, 0o600)
PermissionError: [Errno 13] Permission denied:
'/etc/pki/ca-trust/source/tmpmbqqy6qs'
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component