Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: fpm2 - Password manager with GTK2 GUI
https://bugzilla.redhat.com/show_bug.cgi?id=444830
------- Additional Comments From j.w.r.degoede(a)hhs.nl 2008-05-08 08:44 EST -------
(In reply to comment #6)
(In reply to comment #5)
> Also doesn't the menu entry have an icon? Or is the icon under
> /usr/share/fpm2/pixmaps, and then referenced with an absolute path from
> the .desktop?
Menu entry have icon and is referenced with absolute path. As wrote in packaging
guidelines this is acceptable. FPM2 don't have true icon, it is own logo with
115x56 size and let gnome to scale it itself. You think this is bad way and I
must create single 48x48 icon?
Okay, in that case it can stay as it is. I've done a full review now and
everything looks good except for the dir ownership issue, so please do a new
srpm with that fixed, then I can approve this and sponsor you (once you've
requested cvsextras membership that is).
--
Configure bugmail:
https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.