Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=646836
Mamoru Tasaka <mtasaka(a)ioa.s.u-tokyo.ac.jp> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |mtasaka(a)ioa.s.u-tokyo.ac.jp
--- Comment #1 from Mamoru Tasaka <mtasaka(a)ioa.s.u-tokyo.ac.jp> 2010-10-26 15:35:47
EDT ---
Some notes:
* ruby(abi) dependency
- Writing "Requires: ruby(abi) = 1.8" is a must
https://fedoraproject.org/wiki/Packaging/Ruby#Ruby_Packaging_Guidelines
* Consistent macro usage
- As you defined %geminstdir macro, please use this macro also
in %files section
* Document files
- Please mark document files as %doc properly.
- CHANGELOG.md or so should be marked as %doc
-------------------------------------------
CHANGELOG.md
ISSUES.md
README.md
UPGRADING.md
-------------------------------------------
- Also, the following files
-------------------------------------------
Rakefile
bundler.gemspec (under %geminstdir, not the one under specifications/)
spec/
-------------------------------------------
are not needed on runtime and should be marked as %doc.
We usually move these "unneeded" files to -doc subpackage.
- .gitignore file is not needed and should be removed
* Shipping external project
- This gem bundles external project (for this package thor)
under lib/bundler/vendor/. On Fedora shipping external project in
the same package should (must) be avioded, see:
https://fedoraproject.org/wiki/Packaging/Guidelines#Bundling_of_multiple_...
As Fedora already ships rubygem-thor, please remove this vendorlized
directory and modify scripts in bundler gem to use rubygem-thor rpm.
--
Configure bugmail:
https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.