https://bugzilla.redhat.com/show_bug.cgi?id=1081434
Paulo Andrade <paulo.cesar.pereira.de.andrade(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |paulo.cesar.pereira.de.andr
| |ade(a)gmail.com
--- Comment #15 from Paulo Andrade <paulo.cesar.pereira.de.andrade(a)gmail.com> ---
You can run something like "fedora-review -b 1081434" to
mimic what a reviewer would do.
You should have a %check section. This helps the reviewer
to be more confident that the package is functional. Should
be somewhat like:
%check
LD_LIBRARY_PATH=%{buildroot}%{_libdir}:$LD_LIBRARY_PATH make check
---%<---
I did run it directly from the build, and it fails:
$ LD_LIBRARY_PATH=../libIP2Location/.libs make check
[...]
$ cat test-suite.log
=======================================
IP2Loc 6.0.3: test/test-suite.log
=======================================
# TOTAL: 1
# PASS: 0
# SKIP: 0
# XFAIL: 0
# FAIL: 1
# XPASS: 0
# ERROR: 0
.. contents:: :depth: 2
FAIL: test-IP2Location
======================
IP2Location IPv4 Testing passed.
Test IP Address 2001:0D30:010E:: (Test 11) failed. We got - but expected LA,
Test IP Address 2001:4830:00EA:: (Test 12) failed. We got - but expected US,
Test IP Address 2001:0200:0b01:: (Test 13) failed. We got - but expected JP,
Test IP Address 2001:0388:f000:: (Test 14) failed. We got - but expected AU,
---%<---
There is a bogus wrapper.log file in the tarball btw, that apparently is
from some failed java interface test.
I did a quick look in the sources, and this is a really bad way
to check for big endian :-)
---%<---
#ifdef _SUN_
char * p = (char *) &ret;
/* for SUN SPARC, have to reverse the byte order */
[...]
#else
[...]
#endif
---%<---
This will fail for fedora powerpc64 that is big endian.
It could be interesting if you talk with geoip and geoip-lite
packages maintainer. Apparently a Red Hat employee that should
also be well aware of all issues (as well as legal ones, as I
understand you cannot distribute for free the full database).
But the geoip* packages appear to be in an inconsistent state...
https://admin.fedoraproject.org/pkgdb/package/geoip-geolite/
http://pkgs.fedoraproject.org/cgit/geoip-geolite.git/
and being replaced by a geoip package:
https://bugzilla.redhat.com/show_bug.cgi?id=968074
Do you have any pointers to packages/projects using ip2location?
That could help in bringing more interest from people on it, e.g.
apparently spamassassin uses geoip.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component