https://bugzilla.redhat.com/show_bug.cgi?id=2249863
blinxen <h-k-81(a)hotmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |h-k-81(a)hotmail.com
Doc Type|--- |If docs needed, set a value
--- Comment #2 from blinxen <h-k-81(a)hotmail.com> ---
I took a quick peek at the package
* There are no license files being installed here, probably because the crate
is published without them.
I normally submit a PR upstream that adds the license file. Looking at
upstream here, a simple "cd lz4-sys && ln -s ../LICENSE" should do the
trick
here.
To get this reviewed in the meantime, you can just add the license file
manually and remove it later once your PR has been merged and released.
* Your patch for using the system library looks good. Some comments:
* Consider adding ".print_system_libs(false)" to the pkg-config patch to
prevent linking errors for consumers
* For Fedora you should force the usage of the system library, since this is
the only way we want to link against "libz"
Here is an example of how to do it:
https://src.fedoraproject.org/rpms/rust-libz-sys/blob/rawhide/f/0001-unco...
--
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2249863
Report this comment as SPAM:
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=rep...