https://bugzilla.redhat.com/show_bug.cgi?id=1946365
Robert-André Mauchin 🐧 <zebob.m(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |zebob.m(a)gmail.com
--- Comment #1 from Robert-André Mauchin 🐧 <zebob.m(a)gmail.com> ---
- Remove:
%gopkg
since you're not including it in %files, I guess you don't need it as a
library.
- Since you are bundling I think you could build with GO111MODULE=on
%global gomodulesmode GO111MODULE=on
This hack is then unnecessary:
# With GO111MODULE=off, as set by %%gobuild, `go build` can't find the pflag
# package in the vendor directory. strace shows that it doesn't even look
# in vendor/. This doesn't happen with other dependencies, and I have no
# explanation. Hack around it by explicitly including pflag in the GOPATH.
# mkdir -p %gobuilddir/src/github.com/spf13
# ln -s ../../../../vendor/github.com/spf13/pflag
%gobuilddir/src/github.com/spf13/pflag
- Why do you redefine gobuild for the cross compilation, just doing:
echo "Building macOS Butane..."
export GOOS=darwin
export GOARCH=amd64
%gobuild -o butane-x86_64-apple-darwin internal/main.go
echo "Building Windows Butane..."
export GOOS=windows
export GOARCH=amd64
%gobuild -o butane-x86_64-pc-windows-gnu.exe internal/main.go
should work. Is there something I'm missing there?
- One test fails on 32 bits arches:
--- FAIL: TestReportCorrelation (0.02s)
validate_test.go:239:
Error Trace: validate_test.go:239
Error: Not equal:
expected: 8
actual : 2
Test: TestReportCorrelation
Messages: #4: incorrect error line, raw false
FAIL
exit status 1
See
https://koji.fedoraproject.org/koji/taskinfo?taskID=65319224
https://koji.fedoraproject.org/koji/taskinfo?taskID=65319223
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component