https://bugzilla.redhat.com/show_bug.cgi?id=1586291
--- Comment #2 from Alois Mahdal <amahdal(a)redhat.com> ---
(In reply to Vít Ondruch from comment #1)
I am not going to make a full review, but a few notes, since I
already
opened the .spec file:
* The Source0 is fishy. Why don't you get the sources from GitHub?
* What is the "Release" tag about? Why 0.scratch.1?
Both issues are caused by the fact that I used my experimental "scratch"
version of the SPEC where I use this silly Release and own fork.
* Group tag is not needed anymore.
* Is the "Requires: libslopy" really required? This dependency should be
autogenerated by RPM IMO.
* You should be following CMake guidelines [1].
Thanks!
* You should not need the %post/%postun sections anymore.
I swear I saw it yesterday somewhere, but indeed, it's not in official PG so I
must have been looking at wrong doc.
Anyway, thanks a lot for your notes, Vít, I'll post an updated version soon!
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component