Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Merge Review: perl-XML-LibXML
https://bugzilla.redhat.com/show_bug.cgi?id=226287
bugzilla(a)redhat.com changed:
What |Removed |Added
----------------------------------------------------------------------------
Severity|normal |medium
Priority|normal |medium
Product|Fedora Extras |Fedora
panemade(a)gmail.com changed:
What |Removed |Added
----------------------------------------------------------------------------
AssignedTo|nobody(a)fedoraproject.org |panemade(a)gmail.com
Status|NEW |ASSIGNED
Flag| |fedora-review?
------- Additional Comments From panemade(a)gmail.com 2007-10-22 05:04 EST -------
1)perl as BR is not needed. mock build without it worked successfully.
remove redundant dependency on perl >= 2:5.8.0
2)drop "|| :" from %check
3)you may like to use simple disttag like "2%{?dist}"
4)you may like to use Source URL as
http://www.cpan.org/authors/id/P/PA/PAJAS/XML-LibXML-%{version}.tar.gz
5)rpmlint on SRPM and RPM gave me->
perl-XML-LibXML.i386: W: file-not-utf8
/usr/share/doc/perl-XML-LibXML-1.62001/Changes
The character encoding of this file is not UTF-8. Consider converting it
in the specfile for example using iconv(1).
==> Use iconv command on that file
perl-XML-LibXML.i386: W: dangerous-command-in-%preun perl
perl-XML-LibXML.i386: W: dangerous-command-in-%trigger perl
==>rpmlint suggested not to use perl command but is this some kind of workaround
for some problem?
6)make test skipped one test =>
t/11memory....................ok
26/26 skipped: developers only (set MEMORY_TEST=1 to run these tests)
make test should run all tests.
--
Configure bugmail:
https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.