Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=718317
--- Comment #2 from Mario Blättermann <mariobl(a)freenet.de> 2011-07-03 06:30:21 EDT
---
(In reply to comment #1)
Hi Mario, here are some initial comments:
- The package doesn't build for x86_64 because of the missing compiler flag
-fPIC. You can fix it this way:
* add $(OPT) to all lines calling "gcc -shared" in the Makefiles
* replace OPT='%{optflags}' with OPT='%{optflags} -fPIC' in your spec
file
Hm, there's no "-shared" switch in the Makefile.
- You also must ensure that the plugins get installed below
%{_libdir}.
Currently, they always go to /usr/lib (should be /usr/lib64 on x86_64).
* add ASLIBDIR='%{_libdir}/%{name}' to the make statement in %build
* add ASLIBDIR="$RPM_BUILD_ROOT/%{_libdir}/%{name}" in %install
Done.
- There's an "index out of bounds" warning that can
lead to a segfault. Thus,
I suggest to fix this by dropping the "+1" in line 1832 of
asforca4/asforca4.c. If upstream is still alive, please report it upstream.
There are also some further warnings that require some further attention
by the author.
Patch applied. But upstream is dead (as usual...).
- I think the themes and guile files should be moved from
%{_libdir}/%name to
%{_datadir}/%name
How can I do so? Patching the Makefile?
- add short comments above the PatchX line(s)
Done for the segfault patch.
- drop INSTALL from %doc
Done.
- fix the version number in the %changelog entry
Done.
I've removed the conditional patch for the ppc386 call in the Makefile, because
architecture dependent patches are not allowed (rpmlint told me so). My idea
was a sed command to change this line conditionally. But I've no idea how
"sed"
works... Of course, for now the x86_64 build still fails.
New files:
Spec URL:
http://mariobl.fedorapeople.org/Review/SPECS/asforza4.spec
SRPM URL:
http://mariobl.fedorapeople.org/Review/SRPMS/asforza4-2.10-2.fc15.src.rpm
--
Configure bugmail:
https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.