https://bugzilla.redhat.com/show_bug.cgi?id=1671571
Dridi Boukelmoune <dridi.boukelmoune(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags|needinfo?(dridi.boukelmoune |
|(a)gmail.com) |
--- Comment #18 from Dridi Boukelmoune <dridi.boukelmoune(a)gmail.com> ---
Dominik, as I said, even though we package things dynamically, I don't like the
idea of removing the possibility from end-users. But I can live without it so
really, I don't care.
Justin, the link to the spec file should link to a spec file, not an HTML
document. For your next update, please use this URL for the spec:
https://pagure.io/jflory7-rpm-specs/raw/master/f/rpmbuild/SPECS/playerctl...
Now there are a few things I'm not too happy with in this spec at a single
glance:
The main package should not need to require the -libs sub-package, it should be
detected automatically via linker information in binaries.
If you reuse the summary for the description, at least put a dot at the end:
%description foo
%{summary}.
Install the %license file in all packages.
After that I'll be happy to move on to a formal review, but my availability
will be limited for a couple weeks.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component