Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=736861
--- Comment #7 from Mads Kiilerich <mads(a)kiilerich.com> 2011-11-03 19:33:35 EDT ---
(In reply to comment #6)
Thanks for the comments. Most of it has just been done. Only a couple of
comments:
The description (based on upstreams description) has been changed a lot, so it
should perhaps be reviewed again.
Qscintilla-python already requires PyQt4, so you don't have to
state that
explicitly.
I would like to keep that. It is explicitly stated as a dependency by upstream,
and I like to have the important Qt4 dependency explicit.
README: "The Text interface depends on urwid, pygments and
pyinotify" -- Did
you leave that out on purpose?
I had not updated the package for this new feature. Done now. It is a bit weird
that the package both depends on urwid and qt4, but I don't see any good way to
split it up. I have however tried not to mix these two parts too much.
Spec URL:
http://kiilerix.fedorapeople.org/hgview.spec
SRPM URL:
http://kiilerix.fedorapeople.org/hgview-1.4.0-2.fc15.src.rpm
--
Configure bugmail:
https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.