https://bugzilla.redhat.com/show_bug.cgi?id=1402590
--- Comment #5 from Rex Dieter <rdieter(a)math.unl.edu> ---
naming: ok
sources: ok
09d747c5bf7e071f10c3b0833dd3400b ecryptfs-simple.2016.11.16.1.tar.xz
1. hardended_build, agree with sentiments so far, including the macro here
serves no useful purpose, SHOULD remove it
2. MUST add
BuildRequires: gcc
(gcc-c++ appears unused). all dependencies must be explicitly included (should
not implicitly rely on other packages to pull this in for you).
Given this addition, then you SHOULD remove:
BuildRequires: glibc-devel
(it is a direct dependency of gcc)
3. SHOULD use
make install/fast ...
instead of
%{make_install}
macro (which is tailored for autoconf/automake projects)
4. MUST remove scriptlet:
%post
chmod 4755 %{_bindir}/%{name}
if the binary needs special permissions, either fix in %install or do it via
%attr, not in a scriptlet
5. licensing not ok, MUST change to
License: GPLv2
included ecryptfs-simple.c is clearly v2 only (no ... or later clause).
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component