https://bugzilla.redhat.com/show_bug.cgi?id=1752139
--- Comment #11 from Josh Cogliati jjcogliati-r1@yahoo.com --- First of all, updated urls: Spec URL: https://src.fedoraproject.org/fork/jrincayc/rpms/ucblogo/blob/simplify_packa... SRPM URL: http://jjc.freeshell.org/ucblogo-6.0-27.fc30.src.rpm
[!]: Package use %makeinstall only when make install DESTDIR=... doesn't work. Note: %makeinstall used in %install section
make install DESTDIR does not work, so I added a comment to that effect.
[!]: Patches link to upstream bugs/comments/lists or are otherwise
justified.
I added links to the upstream bugs/comments for the patches I created. I also have created a branch on github for this and emailed the upstream author: https://github.com/jrincayc/ucblog-code-beta/tree/wx_and_other_updates
- Group: is not used in Fedora
Fixed via removing Group:
- Source1: logo-mode.tar.gz
Where does this come from? How is it generated? You must document it in order to be reproducible.
I Removed the emacs logo mode.
- Add Requires: hicolor-icon-theme to own the icons directories.
Fixed.
- Add Requires: emacs-filesystem to own the emacs directories
Fixed via removing logo-mode.
- Add BuildRequires: emacs and use %{_emacs_sitelispdir} instead of %{_datadir}/emacs/site-lisp/
Fixed via removing logo-mode.
I also split out the extra documentation into a -doc package because it was over 1 MB.
I believe this fixes all the current issues that people have found with the package.
Thank you for all the reviews.