https://bugzilla.redhat.com/show_bug.cgi?id=2085444
Miro Hrončok <mhroncok(a)redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |mhroncok(a)redhat.com
--- Comment #26 from Miro Hrončok <mhroncok(a)redhat.com> ---
I've been asked to provide some feedback on the specfile.
%undefine _auto_set_build_flags
%undefine __brp_mangle_shebangs
This absolutely deserves an explanation in the spec file. Why is this needed?
For the shebangs mangling, have you considered explicit opt-out for some files
instead? IDeally, you want to get rid of this.
Summary: Intel(R) SGX SDK
The guidelines say: "Never use (TM) or (R) (or the Unicode equivalents, ™/®).
It is incredibly complicated to use these properly, so it is actually safer for
us to not use them at all."
See
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_trademarks_in...
License: BSD and "Redistributable, no modification
permitted" and MIT and ASL 2.0 and NCSA/MIT and CC0 and FBSDDL and BSD and OpenSSL
and zlib and GPL and BSD/GPLv2 and EPL-1.0
Fedora has switched to SPDX license expression in the meantime. Please see
https://docs.fedoraproject.org/en-US/legal/allowed-licenses/
The "Redistributable, no modification permitted" thing was never supposed to be
in quotes in the first place, but with SPDX this might be hard to express. I
recommend asking for help at the Fedora legal mailing list:
https://lists.fedoraproject.org/admin/lists/legal.lists.fedoraproject.org/
BuildRequires: redhat-rpm-config
This BuildRequires is kinda weird. This package will always be present. I know
that "explicit is better than implicit" but is there anything in particular you
explicitly need from this package?
%description
The Intel(R) SGX SDK is a collection of APIs, libraries, documentation, sample source
code, and tools that allows software developers to create and debug Intel(R) SGX enabled
applications in C/C++.
The same remark about (R) and also "please make sure that there are no lines in
the description longer than 80 characters"
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_summary_and_d...
Group: Development/Libraries
"The Group: tag SHOULD NOT be used."
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_tags_and_sect...
Requires: %{name} = %{version}-%{release} libsgx-urts >=
%{version}-%{release} libsgx-enclave-common >= %{version}-%{release}
(personal opinion) This would have been much more readable if each fo the
requirement was on a separate line / Requires: tag.
%description -n sgxsdk-samples
Intel(R) Software Guard Extensions SDK Sample Code for Developers
The same remark about (R) and also please use sentences in the description
(rpmlint will probably hint that this description does not end with ".").
%files
...
%{_bindir}/*
%{_libdir}/*.so
%{_libdir}/pkgconfig/*.pc
"Packagers SHOULD NOT simply glob everything under a shared directory."
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_explicit_lists
%{_includedir}/sgxsdk
%{_prefix}/lib/sgxsdk
%{_datadir}/sgxsdk
(personal opinion) If those are directories, terminate the lines with a
trailing slash please -- it makes it easier for the reader and serves as one
additional layer of safety (the build would fail then if it is a regular file).
%changelog
%autochangelog
I am not sure you can use %autochangelog without also using %autorelease in the
Release tag.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2085444