Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=505260
Parag AN(पराग) <panemade(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
CC| |panemade(a)gmail.com
AssignedTo|nobody(a)fedoraproject.org |panemade(a)gmail.com
Flag| |fedora-review+
--- Comment #1 from Parag AN(पराग) <panemade(a)gmail.com> 2009-06-11 06:36:41 EDT
---
Review:
+ package builds in mock (rawhide i586).
koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1404843
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
4e1f5b7f716e0bd357e010c9a4a0c6c34f943045 Exception-Class-TryCatch-1.12.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test gave
All tests successful.
Files=1, Tests=45, 0 wallclock secs ( 0.04 usr 0.00 sys + 0.05 cusr 0.01
csys = 0.10 CPU)
+ Package perl-Exception-Class-TryCatch-1.12-1.fc12.noarch =>
Provides: perl(Exception::Class::TryCatch) = 1.12
Requires: perl >= 0:5.005 perl(Exception::Class) perl(Exporter) perl(strict)
+ Not a GUI application
Should:
1) Remove unnecessary
BuildRequires: perl >= 0:5.005
APPROVED.
--
Configure bugmail:
https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.