Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=721144
--- Comment #3 from Mark McLoughlin <markmc(a)redhat.com> 2011-07-20 04:46:51 EDT ---
(In reply to comment #2)
(In reply to comment #1)
> - I don't think euca2ools is actually required; we run all the euca-
> commands inside EC2 instances not locally
When we are doing "upload" or "local" style builds, the euca2ools are
actually
required to do the bundling. See imagefactory/builders/FedoraBuilder.py,
around lines 1383.
Ah, of course - right
I was just about to approve this, but then I remembered to run rpmlint on the
actual RPM itself:
$> rpmlint imagefactory-0.3.1-2.fc14.noarch.rpm
imagefactory.noarch: E: explicit-lib-dependency python-httplib2
imagefactory.noarch: W: conffile-without-noreplace-flag
/etc/pki/imagefactory/cert-ec2.pem
imagefactory.noarch: E: non-executable-script
/usr/lib/python2.7/site-packages/imagefactory/ApplicationConfiguration.py 0644L
/usr/bin/env
imagefactory.noarch: E: non-executable-script
/usr/lib/python2.7/site-packages/imagefactory/Template.py 0644L /usr/bin/env
imagefactory.noarch: E: non-executable-script
/usr/lib/python2.7/site-packages/imagefactory/ImageWarehouse.py 0644L
/usr/bin/env
imagefactory.noarch: E: non-executable-script
/usr/lib/python2.7/site-packages/imagefactory/VMWare.py 0644L /usr/bin/env
imagefactory.noarch: W: no-manual-page-for-binary imgfac.py
1 packages and 0 specfiles checked; 5 errors, 2 warnings.
Re: explicit-lib-dependency - this looks like a false positive to me. See
http://lists.fedoraproject.org/pipermail/devel/2010-March/133955.html
Re: conffile-without-noreplace-flag - do we allow users to replace this with
their own cert? If so, the error is valid.
Re: non-executable-script - do sed -i '/\/usr\/bin\/env python/d'
imagefactory/*.py
Re: no-manual-page-for-binary - there actually is a man page, but not with the
same name as the binary. Do we really want the binary to be installed as
imgfac.py ?
--
Configure bugmail:
https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.