https://bugzilla.redhat.com/show_bug.cgi?id=1720757
Zbigniew Jędrzejewski-Szmek <zbyszek(a)in.waw.pl> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |POST
CC| |zbyszek(a)in.waw.pl
Assignee|nobody(a)fedoraproject.org |zbyszek(a)in.waw.pl
Flags| |fedora-review+
--- Comment #1 from Zbigniew Jędrzejewski-Szmek <zbyszek(a)in.waw.pl> ---
I don't think you need -S git and BR:git-core. Patches formatted by git apply
without trouble by default.
export PYTHONPATH=$PYTHONPATH:%{buildroot}%{python3_sitelib}
That's wrong, surprisingly. This will evaluate to
PTYHONPATH=:/path/to/buildroot/usr/lib/python3.7/site-packages,
and an empty component in path has special meaning of cwd. I think it's
better/safer to write this as:
PATH=%{buildroot}%{_bindir}:$PATH \
PYTHONPATH=%{buildroot}%{python3_sitelib} \
%__python3 -m pytest -v tests
Checklist:
+ package name is OK (it's an application)
+ latest version
+ builds and installs OK
+ license is acceptable for Fedora (MIT)
+ license is specified correctly
+ BR/R/P look OK
+ %python_provide macro is used
+ rpmlint shows nothing important
Package is APPROVED.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component