https://bugzilla.redhat.com/show_bug.cgi?id=2143804
Fabio Alessandro Locati <me(a)fale.io> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags|needinfo?(me(a)fale.io) |
Doc Type|--- |If docs needed, set a value
Assignee|nobody(a)fedoraproject.org |me(a)fale.io
Status|NEW |ASSIGNED
--- Comment #3 from Fabio Alessandro Locati <me(a)fale.io> ---
Hi James,
Glad to see that you managed to package OliveTin.
There are a couple of things to cleanup on the spec file, to start with:
1. Please rename the package to OliveTin (and also this Review Request) so that
it's aligned with the upstream project name as for the known packages exception
in go's Fedora policy
2. Drop the %patch since it is not used
3. Replace the `cp` and `chown` commands in the install section with `install`
4. Use the
https://docs.fedoraproject.org/en-US/packaging-guidelines/Systemd/
policy for the systemd unit
Best,
Fale
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2143804