https://bugzilla.redhat.com/show_bug.cgi?id=1177857
--- Comment #12 from Antonio Trande <anto.trande(a)gmail.com> ---
(In reply to Zbigniew Jędrzejewski-Szmek from comment #11)
%description: please expand SED-ML abbreviation and/or add a few
words
explaining what this package does in a way that is understandable for a lay
person.
%package devel %description: it's enough to say
This package contains headers for %{name}.
Shouldn't python-SEDML be python-libsedml? This would match python-sbml.
https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Addon_Packages_.
28python_modules.29 says: "When in doubt, use the name of the module that
you type to import it in a script."
Also java-libsedml instead of java-SEDML? I think using capitalized SEDML
only makes sense if the actual module name contains that. For ruby, perl, R
that is true, for other bindings not.
Okay.
What about python3 subpackage?
I don't know if Python3 is supported.
I will ask to upstream.
- Packages have proper BuildRequires/Requires on jpackage-utils
Binary package needs that according to
https://fedoraproject.org/wiki/Packaging:Java#BuildRequires_and_Requires.
Okay.
According to
https://fedoraproject.org/wiki/Packaging:Mono, gacutil should
be called in %build.
You meant in %install.
gacutil command fails:
+ mkdir -p
/home/sagitter/rpmbuild/BUILDROOT/libsedml-0.3.0-7.20150422git235bb5.fc22.x86_64/usr/lib/mono/gac
+ gacutil -i build/bindings/csharp/libsedmlcsP.dll -f -package libsedml-sharp
-root
/home/sagitter/rpmbuild/BUILDROOT/libsedml-0.3.0-7.20150422git235bb5.fc22.x86_64/usr/lib
Failure adding assembly build/bindings/csharp/libsedmlcsP.dll to the cache:
Attempt to install an assembly without a strong name
If i remember fine, this error appeared also in libsbml ('gacutil' call is
missing in libsbml, i see). Do you know how to fix it?
I'd use the same license and doc dirs for all subpackages: %global
_docdir_fmt %{name}.
Shouldn't libsedml-sharp require mono-core?
Okay.
Use %make_install macro to replace make DESTDIR=$RPM_BUILD_ROOT install ?
They are equivalent.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component