https://bugzilla.redhat.com/show_bug.cgi?id=1741636
--- Comment #2 from Pat Riehecky <riehecky(a)fnal.gov> ---
Thanks for the review!
I've fixed most of the issues you reported and got a new build in copr[1]
I've got a few questions:
- use perl not %{__perl}
The snippet that generates "perl(:MODULE_COMPAT_5.16.3)" is using %{__perl} and
I thought the %{__perl} macro was best practices based on the snippet....
- You need to include the SystemD macros for
ocsinventory-agent.service
The ocsinventory-agent.service is a one shot designed to be triggered from the
timers. I'm not sure it makes sense to enable it like a normal service.
- Not installable
I've got monitor-edid up for review at
https://bugzilla.redhat.com/show_bug.cgi?id=1743767
--
I'm getting a 403 from rpmlint on the Source0 url, but wget has no problem
fetching that path.
I've added comments in the spec file to help explain some of the rpmlint
complaints:
- the expanded macros in comments are deliberate
- while the package itself contains no binaries, the runtime requirements on
OCS change depending on the arch, so the /usr/bin/ocsinventory-agent package is
arch specific.
[1]
https://copr.fedorainfracloud.org/coprs/jcpunk/ocsinventory-review/packag...
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component