Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=463140
--- Comment #2 from Jaroslav Reznik <jreznik(a)redhat.com> 2008-09-22 06:16:54 EDT
---
First quick look:
- version mismatch
* dfu-utils -V says dfu-util version 0.1+svnexported, newer SVN sets revision
instead exported
- Summary: ended with dot, see rpmlint
- licence problem
* dfu-util is GPLv2+
* dfu-backup is GPLv3
* SPEC file states GPLv2
* split package? use GPLv3? I don't know...
- URL: I think better is
http://wiki.openmoko.org/wiki/Dfu-util (the SPEC's one
is more generic, this one is for dfu-util program).
- Source0: it's from SVN? so you should add comment how to obtain source
codes... and better - ask upstream for proper release of 0.1 version
- Source1: missing URL, where can I download it? and again, splitting packages
should be option?
- Requires: libusb is unneeded?
- Description: "In addition to firmware..." line is too long, see rpmlint
--
Configure bugmail:
https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.