https://bugzilla.redhat.com/show_bug.cgi?id=1140403
--- Comment #5 from Raphael Groner <projects.rg(a)smart.ms> ---
Christan, thanks for your review. All found issues are fixed.
Spec URL:
https://raphgro.fedorapeople.org/review/dreamchess/dreamchess.spec
SRPM URL:
https://raphgro.fedorapeople.org/review/dreamchess/dreamchess-0.2.1-2.RC1...
Rawhide build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=7575357
(In reply to Christian Dersch from comment #4)
Issues:
=======
- Package uses either %{buildroot} or $RPM_BUILD_ROOT
Note: Using both %{buildroot} and $RPM_BUILD_ROOT
See:
http://fedoraproject.org/wiki/Packaging/Guidelines#macros
==> You can remove "rm -rf $RPM_BUILD_ROOT" for current Fedora releases
(but
required for EPEL5)
done.
[!]: License field in the package spec file matches the actual
license.
Note: Checking patched sources after %prep for licenses. Licenses found:
"BSD (3 clause)", "GPL (v2 or later)", "GPL (v3 or
later)", "Unknown or
generated". 4 files have unknown license. Detailed output of
licensecheck
in /home/review/1140403-dreamchess/licensecheck.txt
==> Please check this, licensecheck.txt is below, but BSD license is also
mentioned in COPYRIGHT file
done.
[!]: Package requires other packages for directories it uses.
Note: No known owner of /usr/share/dreamchess
[!]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/share/dreamchess
==> Please check this
done.
[!]: Package complies to the Packaging Guidelines
==> You are packaging RC1, not the final version! Please add this
information in release tag
https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Package_Versioning done.
[!]: Fully versioned dependency in subpackages if applicable.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
dreamchess-
data
==> Please fix this, Requires: %{name}-%{version} instead of %{name}
done.
[!]: Spec use %global instead of %define unless justified.
Note: %define requiring justification: %define _suffix -RC1, %define
_engine dreamer
==> Please adjust this when fixing spec
done.
licensecheck.txt
…
Unknown or generated
--------------------
dreamchess-0.2.1-RC1/src/dreamer/pgn_scanner.c
Cause the corresponding header is
licensed properly, assume this file admits
it.
dreamchess-0.2.1-RC1/src/include/git_rev.h
Could be ignored for
licensing cause it gives only a checkout revision.
dreamchess-0.2.1-RC1/src/macosx/makeapp.pl
MacOS? Perl? Not
needed build script. Ignored.
dreamchess-0.2.1-RC1/src/pgn_scanner.c
Cause the corresponding
header is licensed properly, assume this file admits
it.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component