Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=529198
--- Comment #8 from Thomas Spura <tomspur(a)fedoraproject.org> 2010-01-27 17:17:50 EST
---
Thanks for the review.
(In reply to comment #6)
In short, the only issues I found were:
* MUST: Each package must consistently use macros. [17]
ISSUE.
It uses $RPM_BUILD_ROOT and %{optflags}.
Now it is %{buildroot} and %{optflags}.
(In reply to comment #7)
Just for completeness and because David asked to become a sponsor
recently:
(In reply to comment #6)
> ISSUE. It has a .pc file, but no "Requires: pkgconfig".
Strictly speaking this is not needed any longer because rpm nowadays detects
this automatically:
Not needed = no blocker at all ;)
But requiring it now, till the guidelines hopefully change.
Please add INSTALL='install -p' to 'make install...'
Done.
(Also updated to a new version.)
Spec URL:
http://tomspur.fedorapeople.org/review/pynac.spec
SRPM URL:
http://tomspur.fedorapeople.org/review/pynac-0.1.11-1.fc12.src.rpm
--
Configure bugmail:
https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.