https://bugzilla.redhat.com/show_bug.cgi?id=1649713
Michael Scherer <misc(a)zarb.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |misc(a)zarb.org
--- Comment #2 from Michael Scherer <misc(a)zarb.org> ---
So, I can sponsor Milind.
So reading the spec files quickly, there is a few things to clean:
1) There is no more need for BuildRoot, that's done automatically:
BuildRoot: %(mktemp -ud %{_tmppath}/%{name}-%{version}-%{release}-XXXXXX)
2) The same goes for defattr()
3) Requires: selinux-policy >= %{selinux_policyver} seems curious, where
does POLICY_VERSION come from ?
4) that's minor, but I think SELinux should have the right case in the summary
5) the %files install things in %{_datadir}/selinux/devel/, but there is no
requires on the packages that own that directory (selinux-policy-devel), that
seems incorrect (and I found that container-selinux has the same problem).
6) for consistency, I would reuse the macro %modulename in
%attr(0644,root,root) %{_datadir}/selinux/devel/include/contrib/glusterd.if
7) I am sure we need to have the file in /var/lib/selinux/ tagged with %ghost,
especially since that seems to be a internal directory of selinux, so that may
change in the future.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component