https://bugzilla.redhat.com/show_bug.cgi?id=1878898
--- Comment #2 from Aleksei Bavshin <alebastr89(a)gmail.com> ---
(In reply to Bob Hepple from comment #1)
Hi Bob,
I'm afraid that the construct:
BuildRequires: cmake(nlohmann_json)
... has thrown me!! I can see many similar constructs in Fedora spec files
so I'm sure it must be legal, but the packaging guidelines don't document it
(I'm looking at
https://docs.fedoraproject.org/en-US/packaging-guidelines/CMake/) and I
can't google anything about buildrequires: cmake(...)
Indeed, that's not documented. I created a ticket[1] for Fedora packaging
committee to address that.
`BuildRequires: cmake(...)` is a construction similar to `BuildRequires:
pkgconfig(...)` with the main difference that it works with CMake configuration
files and uses names suitable for CMake's `find_package` dependency resolver.
In the case of this package, meson uses CMake dependency resolver when
pkgconfig lookup fails, thus I'm declaring the dependency as
`cmake(nlohmann_json)`
I did a quick search and the only document I found was a blog post of the
author of the dependency generator[2]. You can check it for a better explanaion
and examples.
[1]
https://pagure.io/packaging-committee/issue/1019
[2]
https://www.dvratil.cz/2015/03/fedora-rpm-automatic-provides-for-cmake-pr...
So I understand there is a subproject
https://github.com/nlohmann/json
package and the code is included in the nwg-launchers tarball. So far so
good.
No, nlohmann_json code is not included in the nwg-launchers tarball.
`cmake(nlohmann_json)` pulls `json-devel` package which would provide the
library.
`dnf install 'cmake(nlohmann_json)'` should do the same for you.
2/ The license for the nlohmann stuff is MIT so please reflect that
in the
spec file with an appropriate comment eg:
3/ ...
4/ ...
5/ ...
Since the subproject is not included in the nwg-launchers source archive, this
would be unnecessary.
7/ how would you feel about adding the following to the description
(or
paraphrasing it):
it must work well on sway;
it should work as well as possible on Wayfire, i3, dwm and Openbox.
It's a good idea. I'll do that.
Thanks for reviewing!
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component