https://bugzilla.redhat.com/show_bug.cgi?id=1670656
Mark Goodwin <mgoodwin(a)redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|Review Request: grafana - |Review Request: grafana -
|Grafana is an open source, |an open source, feature
|feature rich metrics |rich metrics dashboard and
|dashboard and graph editor |graph editor
--- Comment #2 from Mark Goodwin <mgoodwin(a)redhat.com> ---
Spec URL:
https://raw.githubusercontent.com/goodwinos/grafana/native-rpm-spec/packa...
SRPM URL:
http://people.redhat.com/~mgoodwin/grafana/grafana-5.4.3-3.fc28.src.rpm
COPR URL:
https://copr.fedorainfracloud.org/coprs/mgoodwin/grafana/
Just some preliminary comments.
thanks. Note this is now in
https://github.com/goodwinos/grafana
native-rpm-spec
(note: native-rpm-spec branch, which is based on the upstream v5.4.3 tag)
Spec URL shouild point at the raw file.
fixed, see new URLs listed above
Summary don't need to duplicate the package name.
fixed
fixed
# Fedora/FSH and config patch
Typo s/FSH/FHS/ also elsewhere in the spec.
fixed
%defattr(-,root,root,-)
Not needed, this is the default.
removed
%post could probably use some systemd macros to be made simpler.
https://fedoraproject.org/wiki/Packaging:Scriptlets#Scriptlets
Generally speaking, %post and %posttrans looks quite complicated and doing too much.
Maybe that could be made simpler ?
these scriptlets are actually taken directly from grafana source
See packaging/rpm/control/{postinst,posttrans}. So I'd need to
discuss upstream before changing them.
Some config files are no marked %config(noreplace).
fixed
Also:
- patched various shebangs and file modes that rpmbuild was complaining about.
- updated the patch and spec to preserve current defaults.ini and to
add distro-defaults.ini - the spec now installs one or the other in
/etc/grafana/grafana.ini depending whether it's a fedora/rhel build
or some other build. So the existing defaults remain unchanged for
grafana.com builds. This will make the patch more palatable upstream.
- since the webpack contains nodejs javascript, added:
ExclusiveArch: %{nodejs_arches}
as per
https://docs.fedoraproject.org/en-US/packaging-guidelines/Node.js/#_exclu...
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component