Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: vkeybd - Virtual MIDI Keyboard
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189889
opensource(a)till.name changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
AssignedTo|bugzilla-sink(a)leemhuis.info |opensource(a)till.name
OtherBugsDependingO|163776 |163778
nThis| |
------- Additional Comments From opensource(a)till.name 2006-09-19 19:47 EST -------
It is too late for me to do a complete review now but there are still some minor
issues:
- please do not use a full path in the .desktop file in the Exec line because
this make the path to the binary hardcoded.
- there are some warnings in build.log in mock: sffile.c:122: warning: ignoring
return value of 'fread', declared with attribute warn_unused_result - see them
all in the attachment.
- ChangeLog is not packaged
- did you ask upstream to include your icon / desktop files? There is already an
desktop file in the upstream tarball, so maybe upstream will include your
improved desktop file.
- the lash patch does not patch the README properly(LADCCA is still mentioned):
- --ladcca bool
+ --lash bool
Specify the support of LADCCA. Give yes or no as the
- the manpage does not mention the --lash option (the upstream version not the
--ladcca option)
- have you submitted lash patch to upstream? (Just out of curiosity, what are
the advantages of lash against ladcca?
- some files have strange permissions, but I don't know whether or not this
needs to be fixed:
$ rpm -vql vkeybd | grep -- -r--r--r
-r--r--r-- 1 root root 2278 Sep 19 23:41
/usr/share/man/man1/vkeybd.1.gz
-r--r--r-- 1 root root 5765 Sep 19 23:41
/usr/share/vkeybd/vkeybd.list
-r--r--r-- 1 root root 282 Sep 19 23:41
/usr/share/vkeybd/vkeybdmap
-r--r--r-- 1 root root 590 Sep 19 23:41
/usr/share/vkeybd/vkeybdmap-german
- changing %{_datadir}/vkeybd to %{_datadir}/vkeybd/ in %files makes it more
obvious that an directory is meant
--
Configure bugmail:
https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.