Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=720435
--- Comment #2 from Jussi Lehtola <jussi.lehtola(a)iki.fi> 2011-07-13 06:27:18 EDT
---
(In reply to comment #1)
(In reply to comment #0)
> epson-inkjet-printer-escpr.src:73: E: hardcoded-library-path in
> /usr/lib/cups/filter/epson-*
Not good. Look here (
https://fedoraproject.org/wiki/Packaging/RPMMacros) for
info how to create a valid path via RPM macros.
It's hardcoded, since the filters are architecture independent and are placed
in /usr/lib even on 64-bit systems. Otherwise I would have of course used
%{_libdir}.
> epson-inkjet-printer-escpr.src: W: invalid-url Source0:
> epson-inkjet-printer-escpr-1.0.4-1lsb3.2.tar.gz
Place correct URI here, e.g.: http://.../source.tar.gz
If you read the note, upstream doesn't release source tarballs.
I have now switched to using the source rpm as the source, which is a bit more
messy than with the extracted tarball.
> epson-inkjet-printer-escpr-debuginfo.x86_64: E:
incorrect-fsf-address
> /usr/src/debug/epson-inkjet-printer-escpr-1.0.4/lib/escpr_sp.h
I suggest you work with upstream to change the address -- but I guess it's
acceptable for Fedora as it is now.
I doubt the version & release fields are OK. I suggest you change the version
to "1.0.4-1lsb3.2" and release to "1".
Please note
http://fedoraproject.org/wiki/Packaging/NamingGuidelines#Non-Numeric_Vers...
> %defattr(-,root,root)
A bit old-style, I suggest to use %defattr(-,root,root, -).
These are equivalent, but I have changed the style.
rpmlint is now at (omitting the fsf-address errors)
epson-inkjet-printer-escpr.src:2: E: hardcoded-library-path in
/usr/lib/cups/filter
epson-inkjet-printer-escpr-devel.x86_64: W: no-documentation
4 packages and 0 specfiles checked; 21 errors, 1 warnings.
http://theory.physics.helsinki.fi/~jzlehtol/rpms/epson-inkjet-printer-esc...
http://theory.physics.helsinki.fi/~jzlehtol/rpms/epson-inkjet-printer-esc...
--
Configure bugmail:
https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.