Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=692466
--- Comment #6 from Vít Ondruch <vondruch(a)redhat.com> 2011-04-08 04:43:36 EDT ---
(In reply to comment #5)
Updated files:
Spec URL:
http://goldmann.fedorapeople.org/package_review/rubygem-kwalify.spec
SRPM URL:
http://goldmann.fedorapeople.org/package_review/rubygem-kwalify-0.7.2-2.f...
Oxana, it looks like the ruby_sitelib line is not required for rubygems (my
previous rubygems submitted and accepted for Fedora didn't have this line).
It's only required for pure Ruby applications.
That is true. You don't need the line.
Vit, I cleaned the spec file.
The "find %{buildroot}%{geminstdir}/bin -type f | xargs chmod a+x" is not
required IMO.
* Licensing
- What is the reason for "and LGPLv2"? I see everywhere mentioned just MIT
* Test suite
- It would be nice if you could execute the testsuite during build process.
* setup.rb could be move into -doc subpackage, since it is not essential
for runtime
--
Configure bugmail:
https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.