Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=225652
Jon Ciesla <limburgher(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |CLOSED
CC| |limburgher(a)gmail.com
AssignedTo|nobody(a)fedoraproject.org |limburgher(a)gmail.com
Resolution| |RAWHIDE
Flag|fedora-review?, needinfo? |fedora-review+
Last Closed| |2012-04-05 10:13:09
--- Comment #6 from Jon Ciesla <limburgher(a)gmail.com> 2012-04-05 10:13:09 EDT ---
Fresh review.
Good:
- rpmlint checks return:
comps-extras.src: W: invalid-license LGPL+
Should be LGPLv2+
- package meets naming guidelines
- package meets packaging guidelines
- license ( ) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream
- package compiles on devel (x86)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file
I've fixed in rawhide and rebuilt, APPROVED, closing.
--
Configure bugmail:
https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.