https://bugzilla.redhat.com/show_bug.cgi?id=1914637
code(a)musicinmybrain.net changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags|fedora-review? |fedora-review+
--- Comment #5 from code(a)musicinmybrain.net ---
Thanks, approved. Changes from original review below:
===== Issues =====
All previous issues remedied.
- Package installs properly.
Note: Installation errors (see attachment)
See:
https://docs.fedoraproject.org/en-US/packaging-guidelines/
See attached root.log. I have determined that the problem is actually in
python3-pyface, which gets brought in by the mayavi extra. I also tested
installing the main package manually and confirmed it installs properly.
Therefore, there is no problem with your submission.
Instead, I filed
https://bugzilla.redhat.com/show_bug.cgi?id=1919444.
===== MUST items =====
Generic:
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "GNU Lesser General Public License,
Version 3", "*No copyright* GNU Lesser General Public License v3.0 or
later". 47 files have unknown license. Detailed output of licensecheck
in /home/reviewer/1914637-python-boututils/licensecheck.txt
[x]: Package complies to the Packaging Guidelines
Python:
[x]: Package meets the Packaging Guidelines::Python
[x]: Final provides and requires are sane (see attachments).
===== SHOULD items =====
Generic:
[x]: Fully versioned dependency in subpackages if applicable.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
python3-boututils , python3-boututils+mayavi
[x]: Package functions as described.
(That should have been marked before.)
[x]: %check is present and all tests pass.
===== EXTRA items =====
Generic:
[!]: Rpmlint is run on all installed packages.
Note: Mock build failed
See:
https://docs.fedoraproject.org/en-US/packaging-
guidelines/#_use_rpmlint
This is due to the python3-pyface bug
https://bugzilla.redhat.com/show_bug.cgi?id=1919444, not a
defect in this submission. Therefore it should be a PASS [x].
Installation errors
-------------------
INFO: mock.py version 2.8 starting (python version = 3.9.1, NVR =
mock-2.8-1.fc33)...
Start: init plugins
INFO: selinux enabled
Finish: init plugins
INFO: Signal handler active
Start: run
Start: chroot init
INFO: calling preinit hooks
INFO: enabled root cache
INFO: enabled package manager cache
Start: cleaning package manager metadata
Finish: cleaning package manager metadata
INFO: enabled HW Info plugin
Mock Version: 2.8
INFO: Mock Version: 2.8
Finish: chroot init
INFO: installing package(s):
/home/reviewer/1914637-python-boututils/results/python3-boututils-0.1.7-0.1.fc34.noarch.rpm
/home/reviewer/1914637-python-boututils/results/python3-boututils+mayavi-0.1.7-0.1.fc34.noarch.rpm
ERROR: Command failed:
# /usr/bin/dnf --installroot /var/lib/mock/fedora-rawhide-x86_64/root/
--releasever 34 --setopt=deltarpm=False --allowerasing --disableplugin=local
--disableplugin=spacewalk install
/home/reviewer/1914637-python-boututils/results/python3-boututils-0.1.7-0.1.fc34.noarch.rpm
/home/reviewer/1914637-python-boututils/results/python3-boututils+mayavi-0.1.7-0.1.fc34.noarch.rpm
--setopt=tsflags=nocontexts
Rpmlint
-------
Checking: python3-boututils-0.1.7-0.1.fc34.noarch.rpm
python3-boututils+mayavi-0.1.7-0.1.fc34.noarch.rpm
python-boututils-0.1.7-0.1.fc34.src.rpm
python3-boututils.noarch: W: spelling-error %description -l en_US Utils ->
Tills
python3-boututils.noarch: W: description-shorter-than-summary
python3-boututils+mayavi.noarch: W: spelling-error Summary(en_US) Metapackage
-> Meta package, Meta-package, Prepackage
python3-boututils+mayavi.noarch: W: spelling-error Summary(en_US) boututils ->
boutiques
python3-boututils+mayavi.noarch: W: spelling-error Summary(en_US) mayavi ->
mayday
python3-boututils+mayavi.noarch: W: spelling-error %description -l en_US
metapackage -> meta package, meta-package, prepackage
python3-boututils+mayavi.noarch: W: spelling-error %description -l en_US mayavi
-> mayday
python3-boututils+mayavi.noarch: W: spelling-error %description -l en_US
boututils -> boutiques
python3-boututils+mayavi.noarch: W: no-documentation
python-boututils.src: W: spelling-error %description -l en_US Utils -> Tills
python-boututils.src: W: spelling-error %description -l en_US postprocessing ->
post processing, post-processing, teleprocessing
3 packages and 0 specfiles checked; 0 errors, 11 warnings.
Source checksums
----------------
https://files.pythonhosted.org/packages/source/b/boututils/boututils-0.1....
:
CHECKSUM(SHA256) this package :
84f22fe0271bad5fd1490088c16b9894557d199821d84d1acc15cc1ac6b935bf
CHECKSUM(SHA256) upstream package :
84f22fe0271bad5fd1490088c16b9894557d199821d84d1acc15cc1ac6b935bf
Requires
--------
python3-boututils (rpmlib, GLIBC filtered):
python(abi)
python3.9dist(future)
python3.9dist(h5py)
python3.9dist(matplotlib)
python3.9dist(netcdf4)
python3.9dist(numpy)
python3.9dist(scipy)
python3-boututils+mayavi (rpmlib, GLIBC filtered):
python(abi)
python3-boututils
python3.9dist(mayavi)
python3.9dist(pyqt5)
Provides
--------
python3-boututils:
python-boututils
python3-boututils
python3.9-boututils
python3.9dist(boututils)
python3dist(boututils)
python3-boututils+mayavi:
python-boututils+mayavi
python3-boututils+mayavi
python3.9-boututils+mayavi
python3.9dist(boututils[mayavi])
python3dist(boututils[mayavi])
Generated by fedora-review 0.7.6 (b083f91) last change: 2020-11-10
Command line :/usr/bin/fedora-review -b 1914637
Buildroot used: fedora-rawhide-x86_64
Active plugins: Python, Shell-api, Generic
Disabled plugins: fonts, SugarActivity, PHP, Ocaml, Java, R, Haskell, C/C++,
Perl
Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component